search

PrestaShop / hummingbird

77 stars 73 forks source link

Fix: issue-340 #627

Closed tblivet closed 1 month ago

tblivet commented 2 months ago
Questions Answers
Description? Fix https://github.com/PrestaShop/hummingbird/issues/340
Type? improvement
BC breaks? no
Deprecations?
Fixed ticket? Fix https://github.com/PrestaShop/hummingbird/issues/340
Sponsor company @PrestaShopCorp
How to test? ⬇️

Most of the points described in the issue have already been addressed. The remaining ones have been tackled as follows:

tblivet commented 2 months ago

Please keep one column for mobile. In the issue, it was just a suggestion from the author.

Hi @Hlavtox, I don't really understand, you want me to remove one column for mobile? I think it's a good optimization as it will concern only devices with screen width < 375. What do you think?

Hlavtox commented 2 months ago

@tblivet Ah sorry, too early in the morning. :-) I meant to keep two columns on mobiles, unless on VERY small screen sizes. We can fit more data without as much scrolling.

tblivet commented 2 months ago

@Hlavtox, I think removing it is not a good idea because with 2 products per line on very small devices, we really lose in terms of visibility. As you say, we can fit more data, but we display more data in a bad way. I suggest keeping this in place but reducing the breakpoint to 360. With the previous value of 375, the new iPhones will display 2 products per line as it will trigger if < 375. If we lower the value to 360, we will also cover Galaxy, and some other phones, which have a width of 360 for their latest models. This way, one column will only display for small and older devices. https://gs.statcounter.com/screen-resolution-stats/mobile/worldwide

I think it's a good compromise. What do you think?

Hlavtox commented 2 months ago

@tblivet Yeah! Good solution. :-) Do you want to move the breakpoint or add another one?

tblivet commented 2 months ago

@Hlavtox, Perfect 👍 No, just move it because it's already a new breakpoint!

tblivet commented 1 month ago

Thank you, @florine2623 🙏 The three dots are just there to indicate that there are pages between page X and page Y. They allow us to keep all the pagination on a single line, instead of showing every page. So, it's normal if they do nothing, they're just visual elements.