search

PrestaShop / hummingbird

77 stars 73 forks source link

Fix: issue-494 #640

Closed tblivet closed 1 month ago

tblivet commented 1 month ago
Questions Answers
Description? Fix https://github.com/PrestaShop/hummingbird/issues/494 : Several style improvements have been made on productcomments.
Type? improvement
BC breaks? no
Deprecations?
Fixed ticket? Fix https://github.com/PrestaShop/hummingbird/issues/494
Sponsor company @PrestaShopCorp
How to test? I think the entire productcomments module needs to be tested.

Before: comments_before

After: comments_after

tblivet commented 1 month ago

Hi @florine2623,

Thank you for the QA !

Bug 1: I have noticed the bug you reported. However, I think this can be fixed outside this PR to address the problem globally if other links in the theme use scroll anchors.

Bug 2: You're right 👍 the "Write your review" button should open the modal directly, so I have made a new commit to correct it.

ps-jarvis commented 1 month ago

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

(Note: this is an automated message, but answering it will reach a real human)