search

PrestaShop / open-source

Sources for www.prestashop-project.org
https://www.prestashop-project.org/
Other
31 stars 38 forks source link

Update Issue managers / ST and SDT members for the project #125

Closed sarahdib closed 2 years ago

sarahdib commented 2 years ago
Questions Answers
Description Update Issue managers / ST and SDT members for the project
Fixed ticket N/A
matks commented 2 years ago

Thank you @sarahdib

PrestaEdit commented 2 years ago

An issue manager is "de facto" a commiter ?

kpodemski commented 2 years ago

@PrestaEdit no, the Issue manager role is completely different 🤔 Committers don't handle Issue categorization, etc.

PrestaEdit commented 2 years ago

This, I know.

But, and as @Progi1984 say me, we could agree that with permissions accorded on GitHub, an issue manager have the committer rights ?

kpodemski commented 2 years ago

That may be true :) but the role is different, and no one expects the Issue manager to approve the code of Pull Requests, etc. 👍

PrestaEdit commented 2 years ago

Let me invite you on this : https://github.com/PrestaShop/productcomments/pull/141#pullrequestreview-1136154485

kpodemski commented 2 years ago

@PrestaEdit

I understand. We cannot precisely control rights for specific user groups. If I'm not mistaken, you're writing about Paul-Noel's accepting the PR, it's completely fine. He didn't have to do it, but he could if the PR was approved after QA tests.

Progi1984 commented 2 years ago

A SDT can approve some PR, as they are code owners of UI Tests,like developers are code owners of the core. A ST can approve PR, as they test PRs and approve them before merging.

Issue Manager / ST are often the same people.

PrestaEdit commented 2 years ago

Thanks for theses informations, @Progi1984 !

It's a good thing too that peoples makes somes reviews, with or without the commiters roles, of course. I will never ask something others, for sure. It's mainly to know/understand the project organization, as there is a lot of changes as this.