PrestaShop / open-source

Sources for www.prestashop-project.org
https://www.prestashop-project.org/
Other
31 stars 37 forks source link

[Request to become a PrestaShop committer] leemyongpakvn #195

Closed leemyongpakvn closed 1 year ago

leemyongpakvn commented 1 year ago

Hello PrestaShop team I worked with PrestaShop since version 1.5 (mostly in theme and module customization) and really shocked when you decided to migrate the project to Symfony. Then I came here to see what is happenning, and realize that I can migrate my old skills to PS 1.7. That was that, I am here for over 1 year and have enough contributions as well as knowledge to continue with PS 8.0. Following @kpodemski and @matks advice, I'm happy to ask you about my wish to become a PrestaShop committer. Have a cool day!

matks commented 1 year ago

Since I invited you twice, obviously I am happy to approve your application 😄

Your application will be valid when 3 maintainers have approved it. I am the first.

One question: now that we are in 2023, what do you think about the idea of migrating to Symfony? What is your opinion about it, now that we have walked this path for 5 years?

leemyongpakvn commented 1 year ago

I read Pablo's articles several times and only understand half of his ideas. As 5 years passed, I think we are in a long road, we can look back but must go forward :) I miss PrestaShop's past simplicity and light-weight much so I'm trying to simplify anything I found in current modules and themes.

kpodemski commented 1 year ago

Yes, yes, yes :)

matks commented 1 year ago

I read Pablo's articles several times and only understand half of his ideas.

I will be happy to help you understand what's missing if I can :) but in July (in 2 days I go will be off for 2 weeks)

leemyongpakvn commented 1 year ago

Don't worry. His articles are self-explanatory and I have a plan to understand another half by more practices in the next 5 years.

matks commented 1 year ago

@jolelievre added a 👍 that means "Yes"!

matks commented 1 year ago

I quote the maintainer guide:

If three maintainers approve the application, the new committer is approved.

You are consequently approved as committer, welcome in the team! ❤️

matks commented 1 year ago

@leemyongpakvn Are you a member of the open source slack space ? 😉 We use Slack to discuss about the project

leemyongpakvn commented 1 year ago

@matks I'm not a member of Slack yet. Please send me an invitation.

kpodemski commented 1 year ago

@leemyongpakvn you can join using an invitation from there: https://www.prestashop-project.org/slack/

later please reach out to via DM :)

leemyongpakvn commented 1 year ago

@kpodemski It looks like I need an @prestashop.com email address to sign in ?

matks commented 1 year ago

@leemyongpakvn No there is 2 slack spaces: one called "PrestaShopCorp" and one "PrestaShop Open Source Project"

You need a prestashop.com email to access "PrestaShopCorp" but "PrestaShop Open Source Project" is public and free

leemyongpakvn commented 1 year ago

@matks I chose [Continue with Goolge] in above slack link and it returns an error Slack_Prestashop_Join_ByGmail

matks commented 1 year ago

@leemyongpakvn you're right 😮

My apologies, this is a configuration mistake. I'm going to see how to solve it.

matks commented 1 year ago

Here is an updated invitation link https://join.slack.com/t/prestashop/shared_invite/zt-1xe2sd7he-zTJheIinZkujzrox68_X2g

I fixed the configuration setting but I need to replace the link on https://www.prestashop-project.org/slack/

matks commented 1 year ago

PR to fix link https://github.com/PrestaShop/open-source/pull/197

leemyongpakvn commented 1 year ago

@matks It's OK now.