PrestaShop / prestafony-project

Some resources to help you migrate PrestaShop to Symfony 3
https://github.com/PrestaShop/prestafony-project/projects/1
11 stars 8 forks source link

Manage multiple descriptions of PrestaShop version in code #32

Closed mickaelandrieu closed 6 years ago

mickaelandrieu commented 6 years ago

We sometimes need PrestaShop code to act according to the version of the Shop.

This can be for addons API, some iframes or retrieve Localisation packs.

Currently, we end up with multiples helpers functions everywhere in the code.

It's time to extract a utility class, and declare it as a service so we can unit test it and rely on it everywhere.

WDYT?

PierreRambaud commented 6 years ago

Agree, service FTW!

mickaelandrieu commented 6 years ago

Closed by https://github.com/PrestaShop/PrestaShop/pull/9174