search

PrestaShop / prestafony-project

Some resources to help you migrate PrestaShop to Symfony 3
https://github.com/PrestaShop/prestafony-project/projects/1
11 stars 8 forks source link

Grid improvement: make the form available in controllers. #45

Closed mickaelandrieu closed 6 years ago

mickaelandrieu commented 6 years ago

For now, in Logs page we have a very custom form.

What we'd better do is re-use the form used in GridPresenter: as it's a Symfony from we have everything we want to retrieve dynamic data here.

sarjon commented 6 years ago

@mickaelandrieu we can already do that. :)

See https://github.com/PrestaShop/PrestaShop/blob/develop/src/PrestaShopBundle/Controller/Admin/Configure/AdvancedParameters/EmailController.php#L99

By the way, if any module alters grid definition with new filters (or removes default), this form will have all modifications. :+1:

mickaelandrieu commented 6 years ago

Where are the docs then? :p