search

PrestaShop / prestashop-specs

Project specifications for PrestaShop's Core features and native modules
https://build.prestashop-project.org/prestashop-specs/
Other
32 stars 26 forks source link

Carriers specs #272

Closed Saimis777 closed 2 years ago

Saimis777 commented 2 years ago
Questions Answers
Description? Please be specific when describing the PR. What did you add, why did you submit it?
Fixed ticket? Fixes #{issue number here} if there is a related issue
marionf commented 2 years ago

@marwachelly yes, it's possible Could you suggest the changes?

marwachelly commented 2 years ago

@marwachelly yes, it's possible Could you suggest the changes?

So I will change the structure and I will add my suggestion.

Thanks,

marionf commented 2 years ago

@marwachelly Could you please re-check this one ? 🙏

Saimis777 commented 2 years ago

@marwachelly could you clarify which default value you have in mind?

marwachelly commented 2 years ago

@marwachelly could you clarify which default value you have in mind?

@Saimis777 I'm talking about my suggession above that you have already accepted. https://github.com/PrestaShop/prestashop-specs/pull/272#discussion_r795734623 https://github.com/PrestaShop/prestashop-specs/pull/272#discussion_r795736096 https://github.com/PrestaShop/prestashop-specs/pull/272#discussion_r795737998 https://github.com/PrestaShop/prestashop-specs/pull/272#discussion_r795755365

So It is ok now. Many thanks!