search

PrestaShop / prestashop-ui-kit

UI kit for PrestaShop Backoffice - A collection of styled components, based on Bootstrap 4
47 stars 28 forks source link

Fix radio buttons html validations #137

Closed NeOMakinG closed 3 years ago

NeOMakinG commented 3 years ago
Questions Answers
Description? Radio button width and height avoid browsers to validate the input
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes https://github.com/PrestaShop/PrestaShop/pull/22942.
How to test? Checkout this PR, build assets, then on PrestaShop, checkout https://github.com/PrestaShop/PrestaShop/pull/22942, modify the prestakit line in package.json, then build assets and see @khouloudbelguith feedback on the PR, test this, if it send an error, then it's fine :)
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.
khouloudbelguith commented 3 years ago

Hi @NeOMakinG,

Using this PR: PrestaShop/prestashop-ui-kit#137, I found only an error in the console Steps to reproduce the issue:

  1. Enable Multistore Context
  2. Create a new shop
  3. Go to BO > Catalog > Categories page
  4. Add a new root category > Save
  5. At this step, you are in the Root category list
  6. Select only the first shop/second shop
  7. Add a new category > the Parent category is not selected
  8. Set only the Name & save
  9. See the error on the console

Issue created here: https://github.com/PrestaShop/PrestaShop/issues/23365

As discussed, this PR is ok :heavy_check_mark:

Thank you!

Progi1984 commented 3 years ago

Thanks @NeOMakinG & @khouloudbelguith