search

PrestaShop / prestashop-ui-kit

UI kit for PrestaShop Backoffice - A collection of styled components, based on Bootstrap 4
47 stars 29 forks source link

Add SCSS variables to storybook #139

Closed NeOMakinG closed 3 years ago

NeOMakinG commented 3 years ago
Questions Answers
Description? External users had no way of reading SCSS variables without having the repository opened, now it's automatically updated inside storybook
Type? improvement
BC breaks? no
Deprecations? no
How to test? npm run storybook and read variables section

image image

PierreRambaud commented 3 years ago

Can be tested by dev I think :)

Progi1984 commented 3 years ago

@PierreRambaud : Can be tested by dev I think :)

@PrestaShop/qa-functional : OK for a QA Dev ?

NeOMakinG commented 3 years ago

I agree, it should be fine :)

Robin-Fischer-PS commented 3 years ago

@NeOMakinG @Progi1984 OK for QA by dev, thanks :)

NeOMakinG commented 3 years ago

Thanks for testing @PierreRambaud