search

PrestaShop / prestashop-ui-kit

UI kit for PrestaShop Backoffice - A collection of styled components, based on Bootstrap 4
47 stars 28 forks source link

Fix modal max height on exception for example #140

Closed NeOMakinG closed 3 years ago

NeOMakinG commented 3 years ago
Questions Answers
Description? Sometime modal has a ultra big height, which cause a centered problem and the modal is going outside of the window
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes https://github.com/PrestaShop/PrestaShop/issues/23497.
How to test? Checkout this branch, build the UIKit, change new-theme path of prestakit to you're local UIKit, build new-theme folder, update a module which cause an exception like boldtext (1).zip, and then check if the exception is correctly displayed

image

khouloudbelguith commented 3 years ago

Hi @NeOMakinG,

Thank you for your help to test this PR :slightly_smiling_face: It is OK :heavy_check_mark: https://drive.google.com/file/d/1aULypeQWzJq5ivUwL3lHFan9nDrDNH5a/view?usp=sharing

Thanks!