search

PrestaShop / prestashop-ui-kit

UI kit for PrestaShop Backoffice - A collection of styled components, based on Bootstrap 4
47 stars 29 forks source link

Improvements: Removing link styling for links styled as button in alert #157

Closed amaury-hanser closed 3 years ago

amaury-hanser commented 3 years ago

Hello there, Sorry for the long title, but I couldn't find a way to phrase it better.

Issue:

When one uses an anchor tag <a> with the class .btn in an alert, the button will be underlined and the color won't be the one from the class .btn.

Markup:

<div class="alert alert-info" role="alert">
  <p class="alert-text">
    This is a info alert with <a href="#">an example link</a>. Click me to delete
  </p>
  <div>
    <a href="//google.com" class="btn btn-secondary">
      I'm an a tag
    </a>
  </div>
</div>

How it looks:

image

How it should look:

image

Fix suggested:

In _alert.scss, replace line 10:

From:

  a {

To:

  a:not(.btn) {

I can't think of any potential issue with this fix, let me know what you think about it. Thank you :)

NeOMakinG commented 3 years ago

Hey @amaury-hanser,

Looks legit to me, if you want to contribute don't hesitate, overwise I'll fix it :)

amaury-hanser commented 3 years ago

PR Open: https://github.com/PrestaShop/prestashop-ui-kit/pull/158