search

PrestaShop / prestashop-ui-kit

UI kit for PrestaShop Backoffice - A collection of styled components, based on Bootstrap 4
47 stars 29 forks source link

Improve prestashop switch design and alignment #162

Closed Hlavtox closed 3 years ago

Hlavtox commented 3 years ago
Questions Answers
Description? I tweaked the styles of Prestashop switches, to fix their misalignment and make them more precise, on any level of zoom. Related to https://github.com/PrestaShop/PrestaShop/pull/25087.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Partially Fixes https://github.com/PrestaShop/PrestaShop/issues/25063, do not close.
How to test? Apply PR and check that forms look better.
Possible impacts? -

switches

hibatallahAouadni commented 3 years ago

Hello @Hlavtox

The switch are well aligned:

image

LGTM, QA :heavy_check_mark:

Thanks!

NeOMakinG commented 3 years ago

@Hlavtox please run stylelint (npm run scss-fix), I won't merge without this :)

NeOMakinG commented 3 years ago

I think these issues are linked with the fact that we updated our rules but didn't run the fix everywhere

Hlavtox commented 3 years ago

@NeOMakinG Style fixed and squashed

NeOMakinG commented 3 years ago

@PrestaShop/prestashop-core-developers It's mergeable, it was just about linters

Progi1984 commented 3 years ago

Thanks @Hlavtox & @hibatallahAouadni