search

PrestaShop / prestashop-ui-kit

UI kit for PrestaShop Backoffice - A collection of styled components, based on Bootstrap 4
47 stars 29 forks source link

btn-light has wrong text color #165

Closed Hlavtox closed 3 years ago

Hlavtox commented 3 years ago

Problem Button element in the UI kit has wrong color in btn-light variant.

Desired look btn-light should have dark text.

How to reproduce Insert <button type="button" class="btn btn-light">Light</button> anywhere in BO.

Screenshot image

NeOMakinG commented 3 years ago

@prestascott what should be the color or even the global behavior?

prestascott commented 3 years ago

Hello everyone,

Thank you @Hlavtox!

@NeOMakinG I agree with David but not completely, btn-light should have dark text but only for the warning and the white button so it becomes readable and accessible. We know that some of our components are not accessible like the primary button, but we're currently working on it!

Hlavtox commented 3 years ago

@NeOMakinG @prestascott Exactly as Scott said, dark color just for -warning and -light variant ;-) https://getbootstrap.com/docs/4.0/components/buttons/