PrestaShop / prestashop-ui-kit

UI kit for PrestaShop Backoffice - A collection of styled components, based on Bootstrap 4
47 stars 28 forks source link

Release 1.2.6 #205

Closed NeOMakinG closed 1 year ago

NeOMakinG commented 1 year ago
Questions Answers
Description? We want to release the UIKit
Type? improvement
BC breaks? no
Deprecations? no
How to test? CI should pass, no need to test as it will be tested on the core
matks commented 1 year ago

@NeOMakinG Do we go for QA?

NeOMakinG commented 1 year ago

@NeOMakinG Do we go for QA?

They said yes!

AureRita commented 1 year ago

Hi @NeOMakinG

Thank you for your PR, I tested it on develop on this seems to partially works.

As you can see, we didn't have the border and we have correctly prestashop-project.org on the files : (the prestashop-project and breadcrumb)

Untitled_ Nov 25, 2022 4_42 PM.webm

(Border)

Untitled_ Nov 25, 2022 4_49 PM.webm

But, as you can see, we have a little issue on the drop down list :

Untitled_ Nov 25, 2022 4_45 PM.webm

Do you know how to correct it ?

Waiting for you feedback

NeOMakinG commented 1 year ago

@AureRita nice catch : https://github.com/PrestaShop/prestashop-ui-kit/pull/208

NeOMakinG commented 1 year ago

@AureRita can be tested again!

matks commented 1 year ago

Thank you @NeOMakinG