search

PrestaShop / pscleaner

This module allows you to check and fix functional integrity constraints and remove default data
http://www.prestashop.com
Academic Free License v3.0
36 stars 107 forks source link

Remove Older Ps versions conditions #25

Closed nenes25 closed 5 years ago

nenes25 commented 5 years ago

Hi,

The module claim to be compatible only with Prestashop > 1.7.1.0 But in the code it still remains some conditions for checking older versions.

Regards,

MathiasReker commented 5 years ago

Can we possible have a new release of PrestaShop Cleaner ?

PierreRambaud commented 5 years ago

this pr needs to be rebased first :/

MathiasReker commented 5 years ago

@PierreRambaud I can do the rebase if needed. There are PR's with nice improvements in many native modules. It could be really nice to have those PR's merged :)

nenes25 commented 5 years ago

Hi, The rebase is done ;)

MathiasReker commented 5 years ago

This PR break the module. I solved the problems here: https://github.com/PrestaShop/pscleaner/pull/38

Robin-Fischer-PS commented 5 years ago

Hello @nenes25 ,

Thank you for the PR :)

The module is OK for cleaning Orders and Customers. However, it's NOK for cleaning Catalog : An error occurs when doing this (see video to see the error).

https://drive.google.com/file/d/1p9JXyfXmYb1p7-Kezzxu8DCxXBNlSZou/view

nenes25 commented 5 years ago

Hi @Robin-Fischer-PS ,

Thanks for the feedback. My bad on this PR (which was a quick one ) i only remove the condition from the file without testing.

After reviewing in details i see that i misunderstand the way the function version_compare works. These tables should not being included if PS version if > 1.7 This is fixed in the last commit

Regards,

PierreRambaud commented 5 years ago

Thanks @nenes25