PrestaShopCorp / bpostshm

3 stars 5 forks source link

1.6.0.11 Validate Order Warnings #16

Closed tchauviere closed 9 years ago

tchauviere commented 9 years ago

Hi @Stigmi,

When I validate my order, two little php warnings come to my error log, here they are :

[23-Feb-2015 17:49:29 Europe/Paris] PHP Notice:  Undefined index: company in /Users/tchauviere/www/prestashop_16011/modules/bpostshm/classes/Service.php on line 316
[23-Feb-2015 17:49:29 Europe/Paris] PHP Notice:  Undefined index: company in /Users/tchauviere/www/prestashop_16011/modules/bpostshm/classes/Service.php on line 316
Stigmi commented 9 years ago

Could you tell me which setting you enabled in order to display warnings (defines.inc.php or php.ini or something else)? Thx

tchauviere commented 9 years ago

defines.inc.php: _PS_MODEDEV set to true (begining of file) and php.ini : error_reporting = E_ALL

should do the trick

Stigmi commented 9 years ago

OK thx, we never really looked at all the PHP warnings. Should we try to get rid of all of them?

tchauviere commented 9 years ago

Yes please, from what I could catch while reviewing your latest version, beside the one I mention above, none were thrown :)

Stigmi commented 9 years ago

OK, latest release should have solved it.

tchauviere commented 9 years ago

Fixed!

tchauviere commented 9 years ago

Hi @Stigmi,

It seems I did reproduce this warning on 1.6.0.11 with Home Delivery bpost carrier used:

[26-Feb-2015 11:13:26 Europe/Paris] PHP Notice:  Undefined index: company in /Users/tchauviere/www/prestashop_16011/modules/bpostshm/classes/Service.php on line 318
Stigmi commented 9 years ago

Hi @tchauviere Could you send us what was the full address used for this order? Do you know what has changed since your previous test? We'll have a look right now. Thx

tchauviere commented 9 years ago

Hi @Stigmi,

I used the default address of John DOE user which is a Parisian one. But I also forced Home Delivery carrier to accept French address. Maybe is this the cause ?

I'll try with a Belgian one and get back to you ASAP

Stigmi commented 9 years ago

OK thx, that's enough information, thx @home delivery method combines two methods: BE and international. Il looks like international was not yet fixed

Stigmi commented 9 years ago

Warning has now been suppressed. Thank you.

tchauviere commented 9 years ago

Fixed!