First review comments

[Quetzacoalt91]

Thanks for the commits of today, there are almost no errors anymore reported by the validator. Keep up the good work.

Here are other comments for the code:

• /dotpay.php
  • The indentation is incorrect. You should have tabs instead of spaces.
  • l.7: The variable $urlc_param seems to be unused.
  • l.16: Because of a bug on PS 1.5, the variable $ps_version_compliancy does not work properly and must be removed.
  • install() function:
  • XOR is not a permitted operator and should be replaced with && and ||
  • Please avoid affectation of variable inside test condition (and even more for a function parameter)
  • hookPaymentReturn() function:
  • Add the following check at the begining of the function:

        if (!$this->active)
            return;

* Check if the customer is properly loaded:

        if (!Validate::isLoadedObject($customer))
            return;

• tpl files
  • <img /> and <br/> must be closed immediately.
  • <center></center> becomes deprecated in HTML5. Please create or use a css class which use text-align:center;
  • /views/templates/hook/payment.php: The comment does not seem to be properly closed. (For more information: http://www.w3schools.com/tags/tag_comment.asp)
  • /views/templates/admin/content.tpl: ID and PIN should be

{l s='ID' mod='dotpay'}

and

{l s='PIN' mod='dotpay'}

[Quetzacoalt91]

Just replace <br> with <br/> and move the style definitions in a css file and we will be good here

[pkarecki]

Style definitions moved to css folder and improved tpl files in v. 1.3.0

[Quetzacoalt91]

Thanks