PrestaShopCorp / dotpay

Dotpay payment module
1 stars 13 forks source link

Fatal error: eval()'d code: Can't use function return value in write context #11

Closed pkarecki closed 9 years ago

pkarecki commented 9 years ago

Problem was reported by one of our merchants:

[PrestaShop] Fatal error in module file :/home/.../classes/module/Module.php(1238) : eval()'d code: Can't use function return value in write context

PrestaShop version 1.6.0.11

User reported that after this error, whole section "Modules" in BO does not work.

pkarecki commented 9 years ago

Fatal error: Can't use function return value in write context in /.../modules/dotpay/dotpay.php on line 236 [PrestaShop] Fatal error in module dotpay: Can't use function return value in write context

pkarecki commented 9 years ago

Issue found: Note: Prior to PHP 5.5, empty() only supports variables; anything else will result in a parse error. In other words, the following will not work: empty(trim($name)). Instead, use trim($name) == false.

Quetzacoalt91 commented 9 years ago

Indeed, I did not see that in this compressed function.

You can post a PR to fix this issue. I'll merge it today if you do it on time. :)

pkarecki commented 9 years ago

Fixed in 1.4.0 :-)

Thanks!