search

PrestaShopCorp / dpdpoland

2 stars 5 forks source link

Continents #10

Closed gaillafr closed 10 years ago

gaillafr commented 10 years ago

https://github.com/PrestaShop/dpdpoland/blob/master/classes/service.php#L45

A list of continents is not generated the same way as in others files. Why setting it differently? What if the merchant creates new zones of overrides the existing ones?

remixaz commented 10 years ago

There is no other way for us to indentify Europe regions because in ps_zone table we only have id_zone and name fields and both fields are dynamic, they can not be used to identify region.

DonatasL commented 10 years ago

Analysed source code. It can not be hard-coded. Merchant must have possibility to assign carriers for particular zones in module settings page. This will help to avoid confusion.

DonatasL commented 10 years ago

Fixed. Implemented functionality to assign carriers for zones in module settings page. No settings are hardcoded anymore.