General comments

[Quetzacoalt91]

• Because DPD Poland is a carrier module, his class must extend CarrierModule to be sure every condition is respected.
• In your ObjectModel, you don't have to set date_add and date_upd, because set are automatically set by the shop.
• The functions addJS and addCSS should be called in the hook 'header', not in the function building the content of the page.
• Files location:
  • All your classes extending DpdPolandController should be in the same folder.
  • Controllers should be stored in the controllers folder
  • Models should be stored in the classes folder
• If possible, avoid the use of the functions serialize / unserialize and prefer jsonEncode / jsonDecode. They may not passe the security review.
• Your created files are not protected enough protected and can be accessed by anybody who knows the path. You should add a generated hash to make your file unfindable and unguessable.
• Classes have ObjectModel behavior but don't extend it
  • Manifest
  • Package
• Inline style is forbidden and CSS attributes must be moved in CSS files.

[Quetzacoalt91]

Everything has been fixed here. We can close this issue.