search

PrestaShopCorp / dpdpoland

2 stars 5 forks source link

Dpdpoland module modifications #20

Closed remixaz closed 9 years ago

remixaz commented 9 years ago

Made configuration page as main when module is not configured; Added DPD banner into each module page; Added a link for technical questions in module help page.

Quetzacoalt91 commented 9 years ago

Hi @remixaz,

About the module description, I guess it would be better if the blocks for the logo and the text description were merged.

remixaz commented 9 years ago

Hi Thomas, you mean settings page?

"Hi @remixaz,

About the module description, I guess it would be better if the blocks for the logo and the text description were merged."

Quetzacoalt91 commented 9 years ago

Yeah, indeed. capture du 2014-10-15 17 52 17

remixaz commented 9 years ago

OK, this will be changed tomorrow morning.

remixaz commented 9 years ago

In order not to change the consistency, I think we should leave logo as it is: settings_page_header arrange_pickup_page

Quetzacoalt91 commented 9 years ago

I do not see how doing this change would break the module. You just have to merge two templates. capture du 2014-10-16 11 55 47

remixaz commented 9 years ago

OK so not only settings page but in all module pages. Should we ask client's opinion?

Quetzacoalt91 commented 9 years ago

Sure, you can ask their opinion if you want to.

remixaz commented 9 years ago

OK we have confirmation from DPD Poland. Changes will be made today.

Quetzacoalt91 commented 9 years ago

Hi @remixaz,

Don't forget to send a new message when the modifications are done or I will never receive a notification. Anyway, your PR is now merged and the changes will be available from tomorrow.

Thanks for your contribution.