search

PrestaShopCorp / dpdpoland

2 stars 5 forks source link

Carriers & Zones #7

Closed gaillafr closed 10 years ago

gaillafr commented 10 years ago

https://github.com/PrestaShop/dpdpoland/blob/master/classes/dpd_classic.service.php#L97

If the customer creates a new zone it will never be assigned. $value is always "1", if ($value && ...) is useless.

https://github.com/PrestaShop/dpdpoland/blob/master/classes/dpd_standard.service.php#L97 https://github.com/PrestaShop/dpdpoland/blob/master/classes/dpd_standard_cod.service.php#L99

giedriusStan commented 10 years ago

this check is left there for possible future situation when this $value variable might not be equal to 1