search

PrestaShopCorp / envoimoinscher

GNU Lesser General Public License v3.0
3 stars 8 forks source link

EnvoiMoinsCher javascript is not overridable #38

Open samy opened 9 years ago

samy commented 9 years ago

In https://github.com/PrestaShop/envoimoinscher/blob/master/views/templates/hook/envoimoinscher_carrier.tpl, we can see the EnvoiMoinsCher javascript is called directly using a script tag.

It should use addJs methods, to be overridable by the current theme

snapeuh commented 9 years ago

I used the module recently and had to duplicate the template in my theme folder, and edit the code to point it to my theme "carrier.js" javascript.

Shouldn't only moving the file to /js/modules/envoimoinscher/js/carrier.js do the trick according to PS guidelines?

Romain.