PrestaShopCorp / gamification

Displays tips in your Back Office to make the best out of your shop
http://www.prestashop.com
Academic Free License v3.0
3 stars 22 forks source link

Add PrestaShop Paylater with PayPlug & Oney banner on Payment page #100

Closed Matt75 closed 2 years ago

Matt75 commented 2 years ago
Questions Answers
Description? This is part of contractual engagement of PrestaShop Corp with PayPlug & Oney : display a promotional banner on BO > Improve > Payment > Payment Methods
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? https://forge.prestashop.com/browse/PAYSHIP-1544
How to test? See below

⚠️ This is part of contractual engagement of PrestaShop Corp with PayPlug & Oney ⚠️

How to test

  1. Go to BO > Modules > Module Manager
  2. Install or Upgrade Gamification module
  3. Go to BO > Improve > International > Localization
  4. Set Default country to France or Italy
  5. Go to BO > Improve > Payment > Payment Methods
  6. If PrestaShop Checkout is already installed and fully onboarded, you should see this promotional block

EN Capture d’écran 2022-05-13 à 11 10 16

IT Capture d’écran 2022-05-13 à 12 41 39

FR Capture d’écran 2022-05-13 à 12 41 22

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2331339152


Totals Coverage Status
Change from base Build 993880076: 0.0%
Covered Lines: 15
Relevant Lines: 349

💛 - Coveralls
Matt75 commented 2 years ago

@marwachelly Hello 😃

Thanks for your work, your issue on reset / uninstall / disable is not a regression of my changes, we encounter this issue with current version too.

It's related to AdminTab enable/disable performed on enable : https://github.com/PrestaShopCorp/gamification/blob/v2.4.0/gamification.php#L164 and disable :https://github.com/PrestaShopCorp/gamification/blob/v2.4.0/gamification.php#L169

I encounter it since years on my side 😆

marwachelly commented 2 years ago

@marwachelly Hello smiley

Thanks for your work, your issue on reset / uninstall / disable is not a regression of my changes, we encounter this issue with current version too.

It's related to AdminTab enable/disable performed on enable : https://github.com/PrestaShopCorp/gamification/blob/v2.4.0/gamification.php#L164 and disable :https://github.com/PrestaShopCorp/gamification/blob/v2.4.0/gamification.php#L169

I encounter it since years on my side laughing

@Matt75,

Thank you for your feedback and your investigation. But I wasn't able to reproduce the bug with dev branch even with a multilanguage shop.

https://user-images.githubusercontent.com/89604350/169554941-58515efb-eb7b-4067-a2b0-0f2e2459753a.mp4

Did I miss something to reproduce the bug on a the dev branch ?

Thanks,

Matt75 commented 2 years ago

Issue is reproduced with current master and dev branch so it's not related to this Pull Request