search

PrestaShopCorp / gamification

Displays tips in your Back Office to make the best out of your shop
http://www.prestashop.com
Academic Free License v3.0
3 stars 22 forks source link

Don't use {$base_url} #75

Closed ghost closed 4 years ago

ghost commented 4 years ago
Questions Answers
Description? {$base_url} is not https
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes https://github.com/PrestaShop/PrestaShop/issues/20878.
ghost commented 4 years ago

I aggre @PierreRambaud but {$urls.xxx} is not availble on the back office which way you propose.

ghost commented 4 years ago

if i follow you the best way is to change this line ?

https://github.com/PrestaShop/PrestaShop/blob/develop/classes/controller/AdminController.php#L2037

PierreRambaud commented 4 years ago

if i follow you the best way is to change this line ?

https://github.com/PrestaShop/PrestaShop/blob/develop/classes/controller/AdminController.php#L2037

Yes by doing this I think:

'base_url' => $this->context->shop->getBaseURL(true) ,
ghost commented 4 years ago

Ok i make a Pr and i close this one.