PrestaShopCorp / mercadopagobr

2 stars 9 forks source link

[URGENT] Fixing three bugs, see description below. #12

Closed ricardobrito closed 9 years ago

ricardobrito commented 9 years ago

BUGS

[1] Mercadopago wasn’t getting the shipping cost on standard checkout [2] MercadoPago wasn't getting the wrapping cost and discounts on standard checkout [3] When using one step checkout and the user is not logged yet, the javascript and css are not loading because displayTopPayment is not working in this use case I mentioned, see steps to reproduce below: _1. Set one step checkout

  1. Add a product into cart
  2. Place order
  3. You will be asked to login
  4. Log in
  5. Click on ‘Accept terms’
  6. The css is not loaded and also the javascript since displayTopPayment not work either_

    ENHANCEMENTS

[4] Including a parent css class to make sure css is only used by module MercadoPago [5] Changing settings.tpl look and feel

Quetzacoalt91 commented 9 years ago

Hi @ricardobrito,

Because you change a hook on this new version, you should create an upgrade file in order to register the new one without having to uninstall / reinstall the module. You can have more information here: http://doc.prestashop.com/display/PS15/Auto-updating+modules

Regards

ricardobrito commented 9 years ago

Hi @Quetzacoalt91,

Thanks for the heads up. I included it, but don't know how to test it. Could you check if is it correct?

Best regards, Ricardo

Quetzacoalt91 commented 9 years ago

Hi @ricardobrito,

I just tried the upgrade and it works. Add a zip of the module on 3.0.0, and a second one with the version 3.0.1, you will see the following notice: capture du 2015-05-04 16 08 20

But I guess we could also unregister the previous hook during the upgrade. :)

Regards

ricardobrito commented 9 years ago

@Quetzacoalt91 That's right :) Done! tks

Quetzacoalt91 commented 9 years ago

Hi @ricardobrito,

Your PR has just been merged and the changes should be available from tomorrow.

Best regards

ricardobrito commented 9 years ago

@Quetzacoalt91 Thanks for answering quickly! Best Regards!