search

PrestaShopCorp / mercadopagobr

2 stars 9 forks source link

Notices appeared with the last changes #6

Closed Quetzacoalt91 closed 9 years ago

Quetzacoalt91 commented 9 years ago

Hi,

I tried the module with your latest changes, and multiple notices are now shown:

Checkout page:

capture du 2015-03-12 10 29 16

As I said in #1, your CSS files should be included with the addCss() function. In /views/templates/hook/checkout.tpl, we still find a css file at the beginning.

ricardobrito commented 9 years ago

Hi @Quetzacoalt91,

I am not able to reproduce this undefined error. Have you set the credentials? Also make sure that the buyer email is different than seller. Please provide the steps to reproduce.

javascript void(0) is fixed.

Apparently when I resolved #1, I did not explain why I didn't use addCss method in checkout.tpl. The reason is that when I am using one step checkout, this method does not work properly (i.e., the css is not loaded after clicking on accept terms checkbox, in order to work I need to force a page refresh). I tested using Prestashop 5.

ricardobrito commented 9 years ago

Please, @Quetzacoalt91, how can I access that page of notices?

ricardobrito commented 9 years ago

Hi @Quetzacoalt91,

If init_point is undefined, this means that the checkout url wasn't created successfully. Therefore, I don't show the standard checkout method on payments. I am curious, how did you force it?

Quetzacoalt91 commented 9 years ago

I never forced anything to appear, and with the latest commits I do not see MercadoPago in the list anymore. But when I use the Settings - Custom Ticket, I get the following notices: capture du 2015-03-13 15 27 59 capture du 2015-03-13 15 28 11 capture du 2015-03-13 15 28 25

ricardobrito commented 9 years ago

Hi @Quetzacoalt91

I am not able to reproduce it, need more information. Please provide me the credentials you are using for selling and buying? Client id, client secret and public key.

Make sure the email of buyer is a test user as well.

Thanks

ricardobrito commented 9 years ago

@Quetzacoalt91, I was able to reproduce. It seems that you are using a production account VS test account. Please use test accounts for both seller/buyer. On my side I will handle this error to avoid the undefined calls.

ricardobrito commented 9 years ago

@Quetzacoalt91 Is there a way we could talk? Skype, gtalk? I would really appreciate.

Quetzacoalt91 commented 9 years ago

Hi @ricardobrito,

You gave me the credentials I'm currently using. They should work then. If needed, we can chat by gtalk. This is the same email address as the one you sent the credentials.

ricardobrito commented 9 years ago

@Quetzacoalt91, thanks. I started a conversation with you.

ricardobrito commented 9 years ago

All issues resolved.

Quetzacoalt91 commented 9 years ago

Sorry to reopen this issue, but another notice is thrown during the checkout process.

Because you do not have a default value for {$window_type}, notices are thrown. They prevent the button (with javascript:void(0)) to work properly.

Quetzacoalt91 commented 9 years ago

After this step capture du 2015-03-16 11 22 31 I still get this notice with the error message: capture du 2015-03-16 11 22 02

ricardobrito commented 9 years ago

hi @Quetzacoalt91,

Just submitted the fix for those issues.

Thanks,

Quetzacoalt91 commented 9 years ago

Hi @ricardobrito,

The issue still appears on my shop (you should try by displaying PHP errors). You should write a default value for $data['window_type'] in the function hookPayment(...) of mercadopago.php

ricardobrito commented 9 years ago

@Quetzacoalt91, hope this is issue is finally closed :)