search

PrestaShopCorp / ogone

0 stars 7 forks source link

Changed module author and renamed some vars #1

Closed studiokiwik closed 10 years ago

studiokiwik commented 10 years ago

changed in validation.php and ogone.php

gaillafr commented 10 years ago

Hi @studiokiwik, did you see my comment about the Tools::getValue() & Tools::getIsset() in validation.php:41 ?

Thank you, Kind regards.

studiokiwik commented 10 years ago

Ok, I will change it for now. Just for note, Ogone can use 2 different methods to send return, $_POST or $_GET (it's configurable). If we want to maintain consistency with their API, we should be able to distinguish between $_POST and $_GET. Also, they are security concerns: for example if Ogone is configured to return via POST, someone can potentially use GET to alter some of the values...

studiokiwik commented 10 years ago

Also, maybe not a best place to ask, is there official substitution for loops like "foreach ($_GET as $key => $value)" ?

gaillafr commented 10 years ago

No we don't have, sorry. Thank you for the fix. Please, let us know when everything is OK ;) Kind regards.

Quetzacoalt91 commented 10 years ago

Hi @studiokiwik,

Thanks for your contribution, your pull-request has just been merged.

Best regards,