search

PrestaShopCorp / paypal

[ARCHIVED] This repository contains old code. Development has moved to https://github.com/202-ecommerce/paypal
7 stars 92 forks source link

Release/3.10.5 #34

Closed thoma202 closed 8 years ago

thoma202 commented 8 years ago

See #29 + Contract and BNCodes

Quetzacoalt91 commented 8 years ago

paypal.php, l. 1361:

$result = Db::getInstance()->ExecuteS('SELECT * FROM ' . _DB_PREFIX_ . 'paypal_order WHERE id_transaction = "' . $id_transaction . '"');

Add an pSQL() call with $id_transaction

Quetzacoalt91 commented 8 years ago

You should take care of your versioning. This PR seems to introduce a new minor version of the module instead of a patch. :1234:

thoma202 commented 8 years ago

@Quetzacoalt91 As requested, I've sanitized and created dedicated css files for the style.

Is it ok for you ?

thoma202 commented 8 years ago

Hi @Quetzacoalt91 Do you have any news on this ?

mmoustai commented 8 years ago

Hello,

You have a high number of errors who need to be solved before accepting this pull request for your major version of Paypal.

download 22

Please correct this following section in priority of your module. [Red one]

Thanks you in advance.

thoma202 commented 8 years ago

Hi @mmoustai We did fixed a lot of errors (almost 5000).

For the few errors left those are errors that I don't know how to fix. image If context exists we use it, this is just a backup in case something weird would happen.

image

I'm still not sure what to do with this error ?

image

When I try to change something it is not taken into account.

image

Same here. moreover I can't find the two spaces validator is talking about.

image

Concerning the escape of variables, this is complicated for us to change as it would mean a whole new test phase on our end, and we already have a lot of delay on the release of this module. Can we skip this so that we'll do it for the next release ?

Thanks