verifyPaymentDatafeed(...) structure improvement

[Quetzacoalt91]

In unionpay.php, the function verifyPaymentDatafeed(...) needs (too ?) many arguments. It would be better if the function is called this way: public function verifyPaymentDatafeed($data) instead of public function verifyPaymentDatafeed($src, $prc, $success_code, $merchant_reference_number, $unionpaydollar_reference_number, $currency_code, $amount, $payer_authentication_status, $secure_hash_secret, $secure_hash)

The whole arguments would be store in the variable $data, defined as an array.

[Quetzacoalt91]

We still can improve it:

• Instead of concatenating every variable manually, you could use the function implode(...) which will do the job for you.
• If you choose the first point, you have to remove the variable $secure_hash and send it separately in the method attributes.

Here is a suggestion for this function, I let you see if it does what we expect from her :)

    public function verifyPaymentDatafeed($dataAry, $secure_hash)
    {
        return $secure_hash == sha1(implode('|', $dataAry));
    }