search

PrestaShopCorp / yousticeresolutionsystem

Other
1 stars 3 forks source link

Validation #2

Closed gaillafr closed 10 years ago

gaillafr commented 10 years ago

Some files does not respect the PrestaShop's coding standards at all. As they are not part of a SDK they should use the PrestaShop's coding standards.

Don't forget to use the validator: https://validator.prestashop.com/

devyoustice commented 10 years ago

As they are not part of a SDK they should use the PrestaShop's coding standards.

Quetzacoalt91 commented 10 years ago

If the content of the folder Youstice comes from a SDK, can you please rename your folder Youstice to sdk ? Or move Youstice in a new sdk folder ? It will be easier for everybody to know what must remain untouched.

devyoustice commented 10 years ago

I trust the naming of a folder won't have an impact on the result of the validation.

gaillafr commented 10 years ago

Yes it does. We are trying to improve the development and structure of our modules to give the community something more 'standard'. We would really appreciate if you could do it asap.

Thank you, regards.

devyoustice commented 10 years ago

Look gentlemen, we've taken quite a step backwards when we forked our library just for you. Reopening past issues and blackmailing is not really the way forward here.