PrestaShopCorp / yousticeresolutionsystem

Other
1 stars 3 forks source link

Updated marketing page and support for registration #29

Closed devyoustice closed 8 years ago

devyoustice commented 9 years ago

This is submitted for early feedback for validation and approval. NOTE: Don't merge this release until further notice.

Special questions:

Known limitations:

devyoustice commented 8 years ago

Any feedback is really appreciated. The sooner, the better.

Quetzacoalt91 commented 8 years ago

Hi @devyoustice,

Including new fonts is allowed. Just take care to store them in the folder views/fonts as you did and add an index.php file. Also, make sure they work in HTTP and HTTPS.

Quetzacoalt91 commented 8 years ago

Your class Translator seems to be a duplicate from the translation system of PrestaShop. You can set your Youtube URLs as a translated text. Here is an example: https://github.com/PrestaShop/gadwords/blob/master/fr.php#L7

Also, describing why you need all this data during the registration would be appreciated.

cc @sdesbrosses

devyoustice commented 8 years ago

Those data are collected essential to carry out the registration. We will add some explanation in a future version, but for now let's do without. As for the translator class, yes it is pretty much a duplicate. The reason why it's part of the SDK is that we need it in other environments, or custom integrations and would like to minimize the differences between the generic SDK and the one included in the this module. Is this OK? URLS: OK, will be set as translatable text.

devyoustice commented 8 years ago

Commit https://github.com/devyoustice/yousticeresolutionsystem/commit/af6fe829b068222836d80191dcb09e72ce43a606 is mergeable and publishable.

devyoustice commented 8 years ago

Hi, could you please give any eta, when our submission is going to get reviewed?

Quetzacoalt91 commented 8 years ago

Hi,

I plan to review modules tomorrow morning. You should have some news at this time.

Best regards

devyoustice commented 8 years ago

Thanks. Does it mean, that (if successfully validated), the module will immediately be available and published by you, or is that a separate process?

Quetzacoalt91 commented 8 years ago

It is a separate process executed each night.

devyoustice commented 8 years ago

hi, any news?

devyoustice commented 8 years ago

Would it be an acceptable compromise this time? We will resolve it later, however, in due time.

Quetzacoalt91 commented 8 years ago

We will see if you change it next time :smile:

devyoustice commented 8 years ago

Question: if we added the translation tags, it would show up in the translation UI, meaning, translators (person) would mistakenly assume, that these texts also would need to be translated into other languages, which, however, is not the case, and thus we can save translation costs and avoid misunderstandings.

Quetzacoalt91 commented 8 years ago

Having this {if $languageCode == 'fr'} is in my opinion a temporary fix for displaying content in your views. That's why I consider this part will be removed later, which makes this translation tags mandatory.

Best regards

devyoustice commented 8 years ago

that is correct. Thanks for the clarification.