Fancybox - Githubissues

PrestaShopCorp / yousticeresolutionsystem

Other

1 stars 3 forks source link

Fancybox #5

Closed gaillafr closed 10 years ago

gaillafr commented 10 years ago

The fancybox plugin is already part of PrestaShop. To avoid any conflicts you cannot include your own version.

devyoustice commented 10 years ago

again, due to generic nature of the SDK, we must ship and use our own fixed version of fancybox plugin. What would happen if the client would run a version that is too old or too new, or simply incompatible version of fancybox? Or simply if the client does not use fancybox at all? Our plugin would not work in those cases, now it always loads properly. It's OK?

devyoustice commented 10 years ago

How about us bundling fancybox into our generic API just like now, but only using it outside Prestashop? For Prestashop we'd be using the one provided by Presta.

prestachris commented 10 years ago

Could you please explain a bit more on how this proposal would affect the code and the flow for the module. We are not understanding your proposal very well.

devyoustice commented 10 years ago

Inside our generic SDK (contents of the Youstice folder) we will bundle our version of the JS. However, the presta-specific code will become 'clever' enough not to load/use it, but instead rely on the one bundled with presta.

prestachris commented 10 years ago

It may be better to amend your proposition to the current code, and we will check to make sure it is a valid amendment.

devyoustice commented 10 years ago

Check the newly pushed version, commit: f9cf09425986ed30c9b14b35627d8f8e47d5d35f or later