Setup prettify, editorconfig, eslint and add a github action

[opensourceally]

Setup prettify, editorconfig, eslint and add the github action of prettier and linter

[Presto412]

@opensourceally Added some comments

[Presto412]

We can start with just prettify for now.

Regards, Priyansh Jain

On Thu, 15 Oct 2020, 22:42 Prashanth Prabhu, notifications@github.com wrote:

@opensourceally commented on this pull request.

In package.json https://github.com/Presto412/CryptoFS/pull/17#discussion_r505706754:

 "prettier": "^2.0.5",

 "webpack": "^4.43.0",

 "webpack-cli": "^3.3.11"

• },

• "gitHooks": {

I see that the following errors are there on linting.

D:\Hacktoberfest\CryptoFS\src\public\js\keymanagement.js 1:19 warning Unable to resolve path to module 'forge' import/no-unresolved

D:\Hacktoberfest\CryptoFS\src\public\js\list.js 35:19 error 'forge' is not defined no-undef 36:18 error 'forge' is not defined no-undef 37:22 error 'forge' is not defined no-undef 39:21 error 'forge' is not defined no-undef

D:\Hacktoberfest\CryptoFS\src\public\js\mainpage.js 1:19 warning Unable to resolve path to module 'forge' import/no-unresolved 64:28 error '$' is not defined no-undef 66:5 error 'grecaptcha' is not defined no-undef

D:\Hacktoberfest\CryptoFS\src\public\js\util.js 35:5 error Assignment to property of function parameter 'el' no-param-reassign 45:5 error Assignment to property of function parameter 'el' no-param-reassign

D:\Hacktoberfest\CryptoFS\src\routes\index.js 27:29 error Arrow function should not return assignment no-return-assign

✖ 11 problems (9 errors, 2 warnings)

I also have tried with "settings": { "import/resolver": { "node": { "extensions": [".js", ".jsx", ".ts", ".tsx"] } } }. But these seems to not work with import of forge.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Presto412/CryptoFS/pull/17#discussion_r505706754, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGJHFRZNLDJAOFIYCD7ONP3SK4UO5ANCNFSM4SQZFSBQ .

[Presto412]

Yes, for now, anything that can't be autofixed, can be left

Regards, Priyansh Jain

On Thu, 15 Oct 2020, 22:43 Prashanth Prabhu, notifications@github.com wrote:

@opensourceally commented on this pull request.

In package.json https://github.com/Presto412/CryptoFS/pull/17#discussion_r505707633:

 "prettier": "^2.0.5",

"webpack": "^4.43.0", "webpack-cli": "^3.3.11"

• },
• "gitHooks": {

As of now husky is intoduced and it is giving me linting errors. Can I suppress the linter for now for the above changes and checkin ??

For this I need to modify "import/no-unresolved": "off", "no-return-assign" : "off", "no-param-reassign" : "off", "no-undef":"off" on eslint.json rules

Please let me know if this is Ok?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Presto412/CryptoFS/pull/17#discussion_r505707633, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGJHFR5UPQIWYRVH63HWRZLSK4UUVANCNFSM4SQZFSBQ .

[Presto412]

thanks @opensourceally

[opensourceally]

thanks @opensourceally Should we work on fixing the lint ones as well?

[Presto412]

Just did that, pushed the changes :)

Regards, Priyansh Jain

On Thu, 15 Oct 2020, 23:10 Prashanth Prabhu, notifications@github.com wrote:

thanks @opensourceally https://github.com/opensourceally Should we work on fixing the lint ones as well?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Presto412/CryptoFS/pull/17#issuecomment-709483704, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGJHFRYMFLESO7PRXZY5IFTSK4XY7ANCNFSM4SQZFSBQ .