search

PrestonKnopp / language-gdscript

gdscript language grammar package for atom.io
https://atom.io/packages/lang-gdscript
MIT License
32 stars 9 forks source link

Atom install error #17

Closed e-e closed 5 years ago

e-e commented 5 years ago

Attempting to install from the editor results in the following error:

install-error.txt

PrestonKnopp commented 5 years ago

Hi, sorry about the late response. Can you try running xcode-select --install and then reinstall the plugin?

If needed additionally run xcode-select --reset. If Xcode path hasn't modified before you won't need to run the reset command.

PrestonKnopp commented 5 years ago

Hey just bumping this issue, has the above remedied the install error?

I wonder if it would be best to upload a prebuilt binary for macOS as is done for Windows.

thomaskeschl commented 5 years ago

I can verify that running both the --install and --reset commands allowed me to install the plugin after a similar error. Additionally, I had to run sudo xcodebuild -license in order to agree to the license before xcode would run.

After completing those steps, the plugin installed just fine. If there is an option to prebuild the plugin and distribute the binary that will work with apm, that would probably be best to do from the end user perspective. Just food for thought.

PrestonKnopp commented 5 years ago

Awesome, thank you for verifying and for the food for thought. I am now planning on distributing prebuilt macOS binaries and I'll keep this issue open until I get around to it.

BrandonDyer64 commented 5 years ago

Does it need tree-sitter-gdscript? I don't have sudo access on my Mac and I'd like to be able to open Godot scripts with syntax highlighting

PrestonKnopp commented 5 years ago

@BrandonDyer64 It will going forward as I will be dropping the legacy text mate grammar.

I have now uploaded prebuilt mac binaries. If you have a chance could you try (re)installing the lang-gdscript package? It should now download the binaries and install without needing sudo access.