search

PrestonKnopp / language-gdscript

gdscript language grammar package for atom.io
https://atom.io/packages/lang-gdscript
MIT License
32 stars 9 forks source link

Feature Request: Adding Setting to load legacy text-mate grammar as default at .gd files. #44

Closed Jean28518 closed 3 years ago

Jean28518 commented 3 years ago

Hey,

at first great work.

Atom is connected to the GoDot Language server but doesn't do syntax highlighting: grafik

For me that's okay, I don't need such fancy autocomplete. It would be great, if you could add a setting that this automtatic connecting to the GoDot Language Server is disabled per default, and the default grammar of .gd files is the GDScript (Legacy Textmate Grammar) instead.

Thank you very much!

Greetings Jean

Rockster160 commented 3 years ago

👍 To this. The file server is extremely slow and causes my Atom to freeze every time I try to make a change. All I want is some reasonable syntax highlighting. Anything extra should be an option.

PrestonKnopp commented 3 years ago

Hi, thanks for posting an issue and I apologize for the late response.

add a setting that this automtatic connecting to the GoDot Language Server is disabled per default

I can add a setting for this. It will be an opt-out setting as it is probably a better user experience (when it works) to have the language client automatically connect.

default grammar of .gd files is the GDScript (Legacy Textmate Grammar) instead

I won't make the legacy grammar the default as it is being phased out. Also, I'd like to improve the tree-sitter (GDScript) grammar.

When the GDScript grammar stops working I appreciate the issues raised. I don't follow atom, electron, or node's releases so the ABI versions often differ from the GDScript builds.

Jean28518 commented 3 years ago

Thanks for your answer! For me the problem is fixed, now everything is working fine. Thanks for adding the Q&A in your addon description!

PrestonKnopp commented 3 years ago

Cool, I'm glad the problem is fixed. I added a setting that allows the language server client to be disabled, too.