I don't know how we got this far without discovering this issue . . . :-P
I was trying out our package this morning and discovered that I could not import our package from outside the repo. I investigated and discovered that our setup.py was still using the old CamelCase names for our packages. Therefore, our packages were never actually being added to Python's global package namespace (or whatever it is called).
The changes in this PR fix this issue. Note that after changing setup.py, I discovered that the imports in our top-level __init.py__ no longer worked, evidently because they were prefixed with easy_music_generator which is now redundant because the easy_music_generator package is now visible everywhere.
With these changes, the following work from anywhere on my computer:
import easy_music_generator
and
from easy_music_generator import preprocessor
Also, with these changes, assuming that I have a music folder in the current directory, I can run our example.py from outside the repo. In other words . . .
While I was sorting all this out, I also noticed that we (probably me) added easy_music_generator to the path to music in example.py. I removed that because example.py should use the music folder in the examples directory, as described in our README.md.
Even though we are in the 11th hour, we should take these changes because the graders will almost certainly check to see if they can import our package outside of our repo to verify that our setup works correctly--which it currently does not . . . :-(
I don't know how we got this far without discovering this issue . . . :-P
I was trying out our package this morning and discovered that I could not import our package from outside the repo. I investigated and discovered that our
setup.pywas still using the old CamelCase names for our packages. Therefore, our packages were never actually being added to Python's global package namespace (or whatever it is called).The changes in this PR fix this issue. Note that after changing
setup.py, I discovered that the imports in our top-level__init.py__no longer worked, evidently because they were prefixed witheasy_music_generatorwhich is now redundant because theeasy_music_generatorpackage is now visible everywhere.With these changes, the following work from anywhere on my computer:
import easy_music_generatorand
from easy_music_generator import preprocessorAlso, with these changes, assuming that I have a
musicfolder in the current directory, I can run ourexample.pyfrom outside the repo. In other words . . .While I was sorting all this out, I also noticed that we (probably me) added
easy_music_generatorto the path tomusicinexample.py. I removed that becauseexample.pyshould use themusicfolder in theexamplesdirectory, as described in ourREADME.md.Even though we are in the 11th hour, we should take these changes because the graders will almost certainly check to see if they can import our package outside of our repo to verify that our setup works correctly--which it currently does not . . . :-(