PretendoNetwork / .github

Information on the WIP Custom Nintendo WiiU/3DS/2DS server and service replacements
GNU Affero General Public License v3.0
922 stars 21 forks source link

Update contribution guide to mention the scope of pull requests #74

Closed jonbarrow closed 1 week ago

jonbarrow commented 1 month ago

Changes:

Updates the Pull Requests section to mention the scope of pull requests. The goal of this is to prevent pull requests like https://github.com/PretendoNetwork/Volbeat/pull/3 in the future, where a single pull request attempts to target multiple unrelated issues.

The example pull request is not a huge issue, just using it as an example as the first one I saw. However for bigger pull requests, with many other changes, it can become an issue. The goal is to limit the scope of a pull request so that the specific changes for the issue it's targeting can be discussed individually, rather than trying to mix multiple conversations.