search

PretendoNetwork / Nimble

Wii U Pretendo Network BOSS setup module (Aroma)
GNU General Public License v2.0
59 stars 11 forks source link

Always doing OSDynload_Acquire for nn_olv might alter memory layout #9

Closed Maschell closed 5 months ago

Maschell commented 1 year ago

The title patcher always acquires the nn_olv which might change the memory layout and cause problems/crashes for certain games.

It would be better to check if the .rpl is actually loaded (See OSDynLoad_IsModuleLoaded and OSDynLoad_AddNotifyCallback) instead of always loading it

ashquarky commented 1 year ago

The intent is to pre-empt games that are using DynLoad, but you're right that AddNotifyCallback is the correct solution, assuming games don't do anything weird like deleting all the callbacks. Also applies to Inkay

ashquarky commented 1 year ago

Fixed for Inkay in PretendoNetwork/Inkay@16b5c5d9e192b7502503a52a35f9607bb91ee1dd. Dunno if we're gonna fix it for Nimble tbh; unless there's a particular game that's not working.

Maschell commented 1 year ago

unless there's a particular game that's not working.

Apparently Hyrule Warriors is broken: https://www.reddit.com/r/WiiUHacks/comments/11iut7k/i_am_geting_this_error_then_i_start_hyrule/

Maschell commented 1 year ago

Another example of Nimble breaking a game: https://gbatemp.net/threads/exception-dsi-launching-watch-dogs-with-tiramisu-and-other-problems.631946/

ashquarky commented 1 year ago

We're actually in the process of phasing out Nimble entirely and are now only supporting Inkay, just waiting for the documentation to catch up on that. So our official answer to such issues from here is going to be installing Aroma and using Inkay.

If there are games broken by Inkay we will definitely investigate those.

ashquarky commented 5 months ago

Title patcher is no longer in use