search

PretendoNetwork / account

Pretendo account server
GNU Affero General Public License v3.0
54 stars 23 forks source link

Set registration password size requirement to same as Big N's #53

Closed JonAbrams closed 1 year ago

JonAbrams commented 1 year ago

Also remove unnecessary empty string checks in the same file.

JonAbrams commented 1 year ago

For reference: https://en-americas-support.nintendo.com/app/answers/detail/a_id/15994/~/unable-to-create-a-nintendo-account-password

jonbarrow commented 1 year ago

Thank you for the PR! A few notes:

1) PRs should be based off of and merged into the dev branch, yours used master

2) The password size change is incorrect

You are referencing information for Nintendo Accounts, used on the Switch

NNIDs, used on the Wii U and 3DS, have a password size of 6-16 characters

For reference https://en-americas-support.nintendo.com/app/answers/detail/a_id/1083/~/how-to-change-nintendo-network-id-password-settings

image

JonAbrams commented 1 year ago

How embarrassing, apologies! It's probably not worth opening another PR with just removing the empty string comparisons, so I'll just close this.