search

PretendoNetwork / account

Pretendo account server
GNU Affero General Public License v3.0
54 stars 23 forks source link

Updates to NNAS and general touch ups #87

Closed jonbarrow closed 1 month ago

jonbarrow commented 1 month ago

PR touches up some ignored parts of the codebase, including removing unnecessary type declarations and updating comments

Also includes updates to the console status middleware to link 3DS documents to their device certificates. Previously this was not possible due to NASC only getting the LFCS, and NNAS only getting the device certificate. PR #78 added a safe way to do this

This has been tested against a 3DS which did not have the device certificate linked, and was updated correctly. Existing Wii U documents are also handled correctly, however I was not able to test with a fresh Wii U as both of mine are already registered

shutterbug2000 commented 1 month ago

Looks good to me

jonbarrow commented 1 month ago

maybe we should remove the MAC address check from NASC

That sounds fine to me. This PR or another?

DaniElectra commented 1 month ago

That sounds fine to me. This PR or another?

Considering the simplicity of the change, might aswell do it here