search

PretendoNetwork / friends

Pretendo Network friends server
GNU Affero General Public License v3.0
27 stars 7 forks source link

Improve error handling and rename go project #7

Closed DaniElectra closed 11 months ago

DaniElectra commented 11 months ago

Now that we can return errors to nex-protocols-go and it will handle it, we can improve how errors are being handled in friends.

There's probably room for improvement from this, since I haven't added error handling on some database getters due to uncertainties on whether the error should interrupt an action or not.

Although the servers are confirmed to be working, it hasn't been tested extensively, so the PR should be reviewed carefully.

The MongoDB client has also been removed, in favor of GRPC calls to the account server (using GetUserData specifically), and the README style and Makefile from Pikmin 3 has been imported after renaming.

The Go project has been renamed from friends-secure to friends, to keep consistency with the GitHub name.

DaniElectra commented 11 months ago

I've added the missing error handling for database getters. In order to distinguish error types easier, I also added some error constants to avoid collisions with sql.ErrNoRows errors.

We still have the issue about continue processing data when an error occurs on some cases, so I'll wait for more opinions on that