search

PretendoNetwork / nex-protocols-common-go

Reusable implementations of NEX methods found in many servers
GNU Affero General Public License v3.0
19 stars 8 forks source link

Set RVConnectionData time as DateTime #13

Closed DaniElectra closed 1 year ago

DaniElectra commented 1 year ago

Set the structure version to 1 if NEX version is 3.5+

jonbarrow commented 1 year ago

Why is this being done in this library? This feels like something nex-go should handle when encoding the data in the stream

DaniElectra commented 1 year ago

We can't set the version on nex-go because by the time we get to RVConnectionData.Bytes() the structure version is already written in the stream. Unless we set the structure version when creating the structure?

DaniElectra commented 1 year ago

Actually no, my bad. I was thinking that the version was written before calling Structure.Bytes()

Should I close this PR or wait for updating the modules? I actually have to update the time value for RVConnectionData anyway

jonbarrow commented 1 year ago

Is this good to close then?

DaniElectra commented 1 year ago

No, I will use this PR to update the time for RVConnectionData from uint64 to a DateTime

sorry about this confusion lmao