search

PretendoNetwork / nex-protocols-common-go

Reusable implementations of NEX methods found in many servers
GNU Affero General Public License v3.0
19 stars 8 forks source link

Move session creation and notification sending #21

Closed shutterbug2000 closed 1 year ago

shutterbug2000 commented 1 year ago

This helps reduce duplicate code and bugs that result from it. Marked as a Draft for now since it needs testing with lots more games to ensure no regressions happen.

Tested with: Minecraft: Wii U Edition Tri-Force Heroes

Notable games to test still (these worked before this change): Splatoon Mario Kart 8 Mario Kart 7 Kid Icarus: Uprising

DaniElectra commented 1 year ago

Works with Mario Kart 7 :+1:

jonbarrow commented 1 year ago

Confirmed working in Mario Kart 8 :+1:

shutterbug2000 commented 1 year ago

This has now been testing working in Splatoon

DaniElectra commented 1 year ago

@jonbarrow Any objections with merging this?

jonbarrow commented 1 year ago

Nope! Looks good to me :+1: I see it's still a draft, so once it's marked as ready it can be merged

shutterbug2000 commented 1 year ago

Nope! Looks good to me 👍 I see it's still a draft, so once it's marked as ready it can be merged

I've marked it as ready!