PretendoNetwork / nex-viewer

Utility for parsing and (eventually) viewing NEX connections from WireShark network dumps
8 stars 5 forks source link

NEX version checks update #13

Closed jonbarrow closed 1 year ago

jonbarrow commented 1 year ago

NEX versions are just semver, which are non-trivial to accurately compare against

For instance, in some cases we had checks such as major >= 3 && minor >= 5 for validating if something is above NEX 3.5.0. However this breaks down when we have instances where the NEX version is something like 4.0.0. Now suddenly this check fails, because even though 4 is greater than 3, the minor version is smaller

This PR does 3 things

jonbarrow commented 1 year ago

We should add this on nex-go aswell

That's what I'm going to do next