PretendoNetwork / splatoon

Pretendo Splatoon server implementation
GNU Affero General Public License v3.0
33 stars 4 forks source link

feat!: Implement Matchmaking Rewrite #10

Closed AToska21 closed 1 week ago

AToska21 commented 1 month ago

Resolves #9

Changes:

Implements the nex-protocols-common-go matchmaking rewrite.

AToska21 commented 1 month ago

NOTE: For this PR to function with the rewrite, some changes need to be applied to it.

  1. In matchmake-extension/database/find_matchmake_session_by_search_criteria.go, line 77, right after the for loop but before the if statement, add if i == 1 { continue; }.
  2. Replace all instances of ms.max_participants and ms.min_participants with g.max_participants and g.min_participants.
AToska21 commented 1 month ago

Reverted to draft due to Splatfest issues.

AToska21 commented 1 month ago

Splatfests are secondary, it seems to work fine with private and regular battles. And the rewrite was also updated.

shutterbug2000 commented 2 weeks ago

The matchmaking rewrite has a proper release now, so if you update nex-go, nex-protocols-go and nex-protocols-common-go to their latest releases, this will be ready to merge!

Thanks for your contribution!

AToska21 commented 2 weeks ago

The matchmaking rewrite has a proper release now, so if you update nex-go, nex-protocols-go and nex-protocols-common-go to their latest releases, this will be ready to merge!

Thanks for your contribution!

Alright, I'll just update and remove the overrides for the libraries!

AToska21 commented 2 weeks ago

alright, ready to merge!

ashquarky commented 1 week ago

Worked good for me. I wasn't able to actually start a match, but that's cuz my test setup is incomplete - but matchmaking seemed to work well.

MatthewL246 commented 1 week ago

Hey, I think you accidentally included the compiled server in this PR.

AToska21 commented 1 week ago

Hey, I think you accidentally included the compiled server in this PR.

Yeah, I noticed that lmao. my bad