Pretius / Pretius-APEX-Enhanced-Lov-Item

Oracle APEX plugin
MIT License
24 stars 11 forks source link

Missing Parenthesis V104 #21

Open juliusbsimon opened 4 years ago

juliusbsimon commented 4 years ago

Version 1.03 works fine but installing 1.04 on Apex 18.2 results in a missing right parenthesis error no matter what configuration is used.

zhudock commented 4 years ago

I received this error as well, but only when "Use Custom Search Logic" is enabled. I had to look at the APEX Debug Logs, and noticed that the SQL query being assembled by the plugin was invalid. It was appending my custom filter directly after 1=1 rather than including and (my custom filter). If I wrapped my custom filter with and ( ), everything worked as expected

e.g. this

select * 
 from products
where 1 = 1 upper(product_code) like upper(:search_string || '%') or upc like upper(:search_string || '%') 

instead of

select * 
 from products
where 1 = 1 
    and (upper(product_code) like upper(:search_string || '%')
      or  upc like upper(:search_string || '%'))

EDIT:

I see now that this is explained in the help text within APEX itself. Perhaps the corresponding note in the demo app could be updated to reflect the required syntax?

bostrowski commented 4 years ago

@zhudock yes, this is maintained by the plugin help text for the attribute.

I've updated the demo application with the valid SQL query. Help Texts are most important and sometimes I might forget to update demo app ;-)

I'm glad you have found help via help text.

I assume the issue can be closed @zhudock?

zhudock commented 4 years ago

I wasn't the original submitter of the issue, but from my standpoint, i feel the issue can be closed