Prevelate / WebGoat.NET

OWASP WebGoat.NET
0 stars 0 forks source link

CX SQL_Injection @ WebGoat/WebGoatCoins/ProductDetails.aspx.cs [master] #23

Open Prevelate opened 4 years ago

Prevelate commented 4 years ago

SQL_Injection issue exists @ WebGoat/WebGoatCoins/ProductDetails.aspx.cs in branch master

The application's GetProductDetails method executes an SQL query with da, at line 406 of WebGoat\App_Code\DB\MySqlDbProvider.cs. The application constructs this SQL query by embedding an untrusted string into the query without proper sanitization. The concatenated string is submitted to the database, where it is parsed and executed accordingly. The attacker would be able to inject arbitrary data into the SQL query, by simply altering the user input Request, which is read by the LoadComments method at line 53 of WebGoat\WebGoatCoins\ProductDetails.aspx.cs. This input then flows through the code to the database server, without sanitization. This may enable an SQL Injection attack.

Severity: High

CWE:89

Vulnerability details and guidance

Checkmarx

Lines: 55 89 41


Code (Line #55):

            string id = Request["productNumber"];

Code (Line #89):

                string customerNumber = Request.Cookies["customerNumber"].Value;

Code (Line #41):

                string error_message = du.AddComment(hiddenFieldProductID.Value, txtEmail.Text, txtComment.Text);

Prevelate commented 4 years ago

Issue still exists.