search

PreventFlashLoanAttacks / Prevent-Flash-Loan-Attacks

We are dedicated to stopping flash loan and oracle manipulation attacks. Please consider contributing if you have additional information.
https://preventflashloanattacks.com/
BSD Zero Clause License
21 stars 8 forks source link

Nicer favicon & background image #3

Open PatrickAlphaC opened 3 years ago

PatrickAlphaC commented 3 years ago

0.2 ETH to whomever:

  1. Adds a nicer background
  2. Adds a nicer favicon and actually makes it stick to the top
gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.2 ETH (101.24 USD @ $506.2/ETH) attached to it.

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 265 years, 12 months from now. Please review their action plans below:

1) federicosan has been approved to start work.

Do you need a new logo? What about a shield with a lightning for the favicon? Do you have an online version of the site?

Learn more on the Gitcoin Issue Details page.

federicosan commented 3 years ago

Hi Patrick could you please answer my questions? thank you.

PatrickAlphaC commented 3 years ago

Hi @federicosan I messaged you on gitcoin, but I'll add it here too.

  1. Yes, a new logo, and that logo sounds great!
  2. The online version is https://preventflashloanattacks.com/

It's hosted on github pages and uses jekyll

federicosan commented 3 years ago

Thanks! The background is for the hero banner on top?

PatrickAlphaC commented 3 years ago

You got it!

gitcoinbot commented 3 years ago

@federicosan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

federicosan commented 3 years ago

Yes, still making the background and maybe some 3D.

federicosan commented 3 years ago

isometric-03

This is the background I've been working on, I still need to work on the logo, it seems the shield lightning concept is too used, and they're a huge amount of companies using it so I am back to the force field that is less common I will have something to show to you soon.

PatrickAlphaC commented 3 years ago

This is awesome!!! So @adamazad already worked on a logo that I think is very good for now. I think it will make sense to split the bounty up between the two of you.

federicosan commented 3 years ago

@PatrickAlphaC Ok, then I will finish this, export to SVG and png, and upload the illustrator source file. I will also send the other sketches I was doing, and submit a PR for the bounty payment, what do you think?

federicosan commented 3 years ago

@PatrickAlphaC could you please tell me the size of the banner? so I can submit the PR with the correct sizes, If you have a deployed version of the site I can also adapt the background for mobile.

federicosan commented 3 years ago

Ok I will export the art on png and svg and here is the css for the background gradient for it to be responsive.

background: rgb(81,135,170); background: radial-gradient(circle, rgba(81,135,170,1) 0%, rgba(0,82,127,1) 50%, rgba(27,60,108,1) 100%); Could you please tell me where can we test this? I've seen you've change from jekyll to gatsby

PatrickAlphaC commented 3 years ago

I'm just changed back, but it looks like we will be going back to gatsby. Please give it another day for me to update it :)

gitcoinbot commented 3 years ago

@federicosan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

federicosan commented 3 years ago

I am already finished, Will make a PR today. Please let me know if you have some issue with the deliverables.

adamazad commented 3 years ago

@federicosan, please do a clean fork to avoid merge issues on the PR. I did a complete rebase of the repo. Improvements to the design are welcome. https://preventflashloanattacks.com/

federicosan commented 3 years ago

@adamazad Ok, I will see what I can do in addition to the background, I have forked the repo and cloned it and will be checking the code for additional improvements.

gitcoinbot commented 3 years ago

@federicosan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

PatrickAlphaC commented 3 years ago

@federicosan any update here? The background looks great, and I'm looking to do some more bounties. But wondering if I should close this one for now.

In any case. Let me know. Thanks

federicosan commented 3 years ago

Hi, I am working on adding the background to the page, if you like I would just make a pr with the image illustrator file so you can payme for the background, and keep working outside of the bounty to get this working with gatsby, I don't know gatsby so I was following tutorials on how to add background images. What do you think?

adamazad commented 3 years ago

@federicosan, if you post the original copy (or a copy optimized for web), I can add the background in the next push.

I imagine we need to consider the options in regard to colors. I randomly picked a spectrum of red and yellow. Do you think you can create a nicer color scheme?

PatrickAlphaC commented 3 years ago

@adamazad if you want to take the image from above, it looks like it's the original. Then we can close out this PR. I'm happy to split the bounty between you two.

adamazad commented 3 years ago

Patrick, I'll see how it fits 😄

On Tue, Dec 15, 2020, 9:43 PM Patrick Collins notifications@github.com wrote:

@adamazad https://github.com/adamazad if you want to take the image from above, it looks like it's the original. Then we can close out this PR. I'm happy to split the bounty between you two.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PreventFlashLoanAttacks/Prevent-Flash-Loan-Attacks/issues/3#issuecomment-745486898, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOWISE6G2KCVKM33YOJZGTSU6U35ANCNFSM4T5CNIYQ .

federicosan commented 3 years ago

herobanner jpg-01-01 Here is a version with transparent background you can use this css for the gradient background background: rgb(81,135,170); background: radial-gradient(circle, rgba(81,135,170,1) 0%, rgba(0,82,127,1) 50%, rgba(27,60,108,1) 100%);

federicosan commented 3 years ago

@PatrickAlphaC Anything else needed to pay out the bounty for the background?

PatrickAlphaC commented 3 years ago

I don't think so, could you submit for the bounty? It looks like I can't pay out yet.

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.2 ETH (128.48 USD @ $642.4/ETH) has been submitted by:

federicosan commented 3 years ago

I have submitted work, I don't know why is gitcoinbot not listing my username :/

PatrickAlphaC commented 3 years ago

It's not letting me pay you out either XD I'm asking gitcoin for help as to what's going on.

federicosan commented 3 years ago

I have received an email confirming my submission today, maybe the bot will now detect this.

federicosan commented 3 years ago

Hi @PatrickAlphaC Any news about payout? I contacted gitcoin's support because the bot was not working, they told me you were planning on tipping me and cancel the bountie but I am not sure what they meant.

gitcoinbot commented 3 years ago

⚡️ A tip worth 0.20000 ETH (215.89 USD @ $1079.45/ETH) has been granted to @federicosan for this issue from @PatrickAlphaC. ⚡️

Nice work @federicosan! Your tip has automatically been deposited in the ETH address we have on file.

PatrickAlphaC commented 3 years ago

https://etherscan.io/tx/0x75e677c2748453baa97199c20f6489cba00f41de46365a8f48e499d7a3231431

PatrickAlphaC commented 3 years ago

The UI wasn't working, so I just tipped you the ETH. Thank you! Hope Gitcoin can fix this soon.

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.2 ETH (215.89 USD @ $1079.45/ETH) attached to this issue has been cancelled by the bounty submitter