[WIP] Filedriver refactor

Prezent / doctrine-translatable

Translatable behaviour extension for Doctrine2

MIT License

26 stars 17 forks source link

[WIP] Filedriver refactor #18

Closed sandermarechal closed 9 years ago

sandermarechal commented 9 years ago

Refactor the FileDriver and YamlDriver. The Yaml mapping for translation locales is updated for consistency. A DoctrineAdapter is added to build a metadata driver based on the doctrine driverchain. Advantages:

Better testability for drivers
Ability to keep Doctrine and Translatable mappings separate
Easier configuration through DoctrineAdapter
Better performance for the Yaml driver. The Doctrine driver chain is parsed only once, not for every class.

sandermarechal commented 9 years ago

@jorisvandesande Could you take a look at this refactoring? It changes the Yaml mapping which is a BC break.

jvandesande commented 9 years ago

@sandermarechal Looks fine by me, configuration will be easier this way. I think it's stable enough to make it 1.0 after this changes. Then it's also clear that there have been (breaking) changes. The TranslatableBundle should be updated too, it should use the doctrine adapter to detect the correct metadata driver (by default).